Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touch every file on earth to update copyright #4729

Merged
merged 6 commits into from
Jan 18, 2022
Merged

touch every file on earth to update copyright #4729

merged 6 commits into from
Jan 18, 2022

Conversation

scottbell
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • [N/A] Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • [N/A] Testing instructions included in associated issue?

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #4729 (92885ea) into master (19b3be7) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4729      +/-   ##
==========================================
+ Coverage   56.37%   56.41%   +0.04%     
==========================================
  Files         718      718              
  Lines       22810    22810              
  Branches     1659     1659              
==========================================
+ Hits        12859    12869      +10     
+ Misses       9543     9536       -7     
+ Partials      408      405       -3     
Impacted Files Coverage Δ
platform/commonUI/browse/bundle.js 100.00% <ø> (ø)
platform/commonUI/browse/src/InspectorRegion.js 100.00% <ø> (ø)
...m/commonUI/browse/src/navigation/NavigateAction.js 100.00% <ø> (ø)
...ommonUI/browse/src/navigation/NavigationService.js 66.03% <ø> (ø)
...I/browse/src/navigation/OrphanNavigationHandler.js 100.00% <ø> (ø)
platform/commonUI/dialog/bundle.js 100.00% <ø> (ø)
platform/commonUI/dialog/src/DialogService.js 97.95% <ø> (ø)
platform/commonUI/dialog/src/OverlayService.js 100.00% <ø> (ø)
platform/commonUI/edit/bundle.js 66.66% <ø> (ø)
platform/commonUI/edit/src/actions/CancelAction.js 100.00% <ø> (ø)
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b73bb...92885ea. Read the comment docs.

@unlikelyzero unlikelyzero added pr:visual pr:e2e Automatically triggers e2e tests to run labels Jan 18, 2022
@github-actions
Copy link

@unlikelyzero unlikelyzero self-requested a review January 18, 2022 18:36
@github-actions
Copy link

Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We walked through this PR over a call.

  1. This PR does not audit all current files to verify that they contain a copyright statement.
  2. There is debate as to whether this needs to be updated every year

@shefalijoshi
Copy link
Contributor

Looks good!

@unlikelyzero
Copy link
Collaborator

giphy (1)

@unlikelyzero unlikelyzero merged commit 4a9744e into master Jan 18, 2022
@unlikelyzero unlikelyzero deleted the mct3979 branch January 24, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e Automatically triggers e2e tests to run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants