-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Staleness] API and Component Functionality #6108
Conversation
Merging latest master
…th new staleness functionality
…ng to telemetry tables to facilitate styling of completed components
Codecov Report
@@ Coverage Diff @@
## master #6108 +/- ##
==========================================
- Coverage 54.87% 54.74% -0.14%
==========================================
Files 604 607 +3
Lines 25268 25917 +649
Branches 2303 2343 +40
==========================================
+ Hits 13865 14187 +322
- Misses 10754 11071 +317
- Partials 649 659 +10
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. One code change request. Let me know how much work it is and we can discuss options.
* new StalenessProvider implementations should be | ||
* [registered]{@link module:openmct.TelemetryAPI#addProvider}. | ||
* | ||
* @interface StalenessProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should define the functions of a staleness provider here, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K! let me know if looks ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making the changes.
In initial testing I am seeing an issue when establishing initial staleness - |
I've a strong suspicion that the missing telemetry is explained by akhenry/openmct-yamcs#271 however |
…ness mergin latest from master
Closes #6109
Describe your changes:
Added a Staleness functionality to the Telemetry API. Added staleness functionality/visibility to the following components and sections of Open MCT:
All Submissions:
Author Checklist
Reviewer Checklist