-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dismiss the independent time conductor popup on unmount #6859
Conversation
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/07/2023 11:19:04pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 0f318f9 Started: 08/07/2023 11:17:08pm UTC Current Playwright Test Results Summary✅ 134 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/07/2023 11:19:04pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
3.23% (3)3 / 93 runsfailed over last 7 days |
16.13% (15)15 / 93 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery in Display Layout Resizing the layout changes thumbnail visibility and size
Retry 1 • Initial Attempt |
0% (0)0 / 88 runsfailed over last 7 days |
3.41% (3)3 / 88 runsflaked over last 7 days |
src/plugins/timeConductor/independent/independentTimeConductorPopUpManager.js
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6859 +/- ##
==========================================
+ Coverage 48.31% 48.35% +0.03%
==========================================
Files 643 643
Lines 25626 25627 +1
Branches 2496 2496
==========================================
+ Hits 12381 12391 +10
+ Misses 12768 12760 -8
+ Partials 477 476 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/plugins/timeConductor/independent/independentTimeConductorPopUpManager.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #6842
Describe your changes:
Don't set conductor popup to null unless the view is being destroyed
All Submissions:
Author Checklist
Reviewer Checklist