Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss the independent time conductor popup on unmount #6859

Merged
merged 11 commits into from
Aug 7, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Jul 31, 2023

Closes #6842

Describe your changes:

Don't set conductor popup to null unless the view is being destroyed

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Jul 31, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/07/2023 11:19:04pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 0f318f9

Started: 08/07/2023 11:17:08pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/07/2023 11:19:04pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 0f318f9

Started: 08/07/2023 10:53:06pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
3.23% (3) 3 / 93 runs
failed over last 7 days
16.13% (15) 15 / 93 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery in Display Layout Resizing the layout changes thumbnail visibility and size
Retry 1Initial Attempt
0% (0) 0 / 88 runs
failed over last 7 days
3.41% (3) 3 / 88 runs
flaked over last 7 days

View Detailed Build Results


@shefalijoshi shefalijoshi requested a review from ozyx July 31, 2023 17:39
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #6859 (0f318f9) into master (accfbc9) will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #6859      +/-   ##
==========================================
+ Coverage   48.31%   48.35%   +0.03%     
==========================================
  Files         643      643              
  Lines       25626    25627       +1     
  Branches     2496     2496              
==========================================
+ Hits        12381    12391      +10     
+ Misses      12768    12760       -8     
+ Partials      477      476       -1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.09% <ø> (+<0.01%) ⬆️ Carriedforward from accfbc9
e2e-stable 56.53% <50.00%> (+0.05%) ⬆️
unit 38.77% <0.00%> (+0.06%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/plugins/timeConductor/ConductorAxis.vue 25.71% <0.00%> (ø)
src/plugins/timeConductor/ConductorHistory.vue 45.87% <ø> (ø)
src/plugins/timeConductor/ConductorPopUp.vue 47.61% <ø> (ø)
...ins/timeConductor/independent/IndependentClock.vue 0.00% <0.00%> (ø)
src/plugins/timeConductor/timePopupFixed.vue 33.33% <ø> (ø)
src/plugins/timeConductor/timePopupRealtime.vue 27.02% <ø> (ø)
...ndependent/independentTimeConductorPopUpManager.js 86.04% <50.00%> (-9.20%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update accfbc9...0f318f9. Read the comment docs.

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigating away from a view with an ITC on it is giving me this error and navigating breaks:

image

@shefalijoshi shefalijoshi requested a review from ozyx July 31, 2023 20:36
@ozyx ozyx added this to the Target:3.0.1 milestone Aug 2, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 3, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 3, 2023
@ozyx ozyx enabled auto-merge (squash) August 3, 2023 16:41
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 3, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 3, 2023
@ozyx ozyx disabled auto-merge August 7, 2023 22:51
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 7, 2023
@ozyx ozyx enabled auto-merge (squash) August 7, 2023 23:14
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 7, 2023
@ozyx ozyx merged commit 6a9ff91 into master Aug 7, 2023
@ozyx ozyx deleted the fix-independent-time-conductor branch August 7, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Independent time conductor popup is not dismissed on navigating to a different object
3 participants