[CI] Stabilize visual tests, remove appAction, and update pane buttons #7033

unlikelyzero · 2023-09-03T17:29:21Z

Note: this is blocked on #6990

Describe your changes:

Adds the 'timer create date' css to percyCSS to ignore a changing timestamp on notebooks. Note: we may want to remove this test if it adds no value
Adds a new constant called VISUAL_URL which contains all of the encoded paths necessary to hide the inspector and the tree and put the clock into fixed time
Updates documentation
Adds pane button name attribute to open inspector and tree panes
Removes appAction selectInspectorTab

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

…nd tree

codecov · 2023-09-03T17:33:02Z

Codecov Report

Merging #7033 (23fdb93) into master (8e917b2) will decrease coverage by 0.13%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #7033      +/-   ##
==========================================
- Coverage   55.87%   55.74%   -0.13%     
==========================================
  Files         643      643              
  Lines       25786    25787       +1     
  Branches     2517     2517              
==========================================
- Hits        14407    14375      -32     
- Misses      10684    10715      +31     
- Partials      695      697       +2

Flag	Coverage Δ		*Carryforward flag
e2e-full	`42.04% <ø> (-0.03%)`	⬇️	Carriedforward from 1a0d920
e2e-stable	`57.19% <ø> (+0.04%)`	⬆️
unit	`49.40% <40.00%> (-0.16%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed	Coverage Δ
src/ui/layout/pane.vue	`47.56% <40.00%> (+0.64%)`	⬆️

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e917b2...23fdb93. Read the comment docs.

deploysentinel · 2023-09-03T17:33:59Z

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/11/2023 11:33:35pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 23fdb93

Started: 09/11/2023 11:31:30pm UTC

View Detailed Build Results

Current Playwright Test Results Summary

✅ 138 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/11/2023 11:33:35pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 23fdb93

Started: 09/11/2023 11:20:49pm UTC

⚠️ Flakes

📄 functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds Retry 1 • Initial Attempt	0% (0) 0 / 73 runs failed over last 7 days	45.21% (33) 33 / 73 runs flaked over last 7 days

View Detailed Build Results

…visual-tests

unlikelyzero · 2023-09-11T15:12:16Z

e2e/tests/functional/plugins/imagery/exampleImagery.e2e.spec.js

@@ -233,7 +233,6 @@ test.describe('Example Imagery Object', () => {
  });

  test('Can use the reset button to reset the image @unstable', async ({ page }, testInfo) => {
-    test.slow(testInfo.project === 'chrome-beta', 'This test is slow in chrome-beta');


scottbell

One small change, but looks good otherwise!

e2e/tests/visual/notification.visual.spec.js

unlikelyzero · 2023-09-11T23:02:55Z

e2e/tests/visual/controlledClock.visual.spec.js

  });
  test.use({
    storageState: './e2e/test-data/overlay_plot_with_delay_storage.json',
    clockOptions: {
+      now: MISSION_TIME,


driveby to match the readme

ozyx

LGTM! Just had a question about the prettier bypass

ozyx · 2023-09-11T23:00:50Z

e2e/constants.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */


does prettier mess this file up somehow?

the length of the constants are too long. I figured it'd be a regular thing if we're doing URLs

oh, wild. I didn't know that would fail prettier? does it not except that automatically?

unlikelyzero added 2 commits September 3, 2023 10:28

Add a VISUAL_URL constant and remove all vestiges of hide inspector a…

783a793

…nd tree

hide timer and add concurrency

e872bee

unlikelyzero enabled auto-merge (squash) September 3, 2023 17:29

unlikelyzero requested review from ozyx and jvigliotta September 3, 2023 17:35

unlikelyzero added this to the Target:3.1.0 milestone Sep 3, 2023

unlikelyzero changed the title ~~[CI] Stabalize visual tests~~ [CI] Stabilize visual tests Sep 5, 2023

unlikelyzero added 2 commits September 5, 2023 06:54

Merge branch 'master' into stable-visual-tests

d5eb691

turn off concurrency

46c4c63

unlikelyzero changed the title ~~[CI] Stabilize visual tests~~ [CI] Stabilize visual tests and add pane buttons Sep 6, 2023

unlikelyzero changed the title ~~[CI] Stabilize visual tests and add pane buttons~~ [CI] Stabilize visual tests and update pane buttons Sep 6, 2023

unlikelyzero added 5 commits September 7, 2023 12:15

factor out old appAction

e401cfb

Add expand button to panes

99312d1

remove old slow annotations

0de58cd

fix fault

679e8e8

update domcontentloaded

b3607e1

unlikelyzero changed the title ~~[CI] Stabilize visual tests and update pane buttons~~ [CI] Stabilize visual tests, remove appAction, and update pane buttons Sep 7, 2023

unlikelyzero added 8 commits September 7, 2023 13:49

missed refactor

22d84aa

driveby: setTimeBounds private

e230e9e

Merge branch 'master' of https://github.com/nasa/openmct into stable-…

d20e2a0

…visual-tests

add comments to the percyCSS

44739a1

suggest MISSION_TIME

3f2527c

more notes

78cb5d5

regen

8264955

clean up test

338b01a

unlikelyzero requested a review from scottbell September 11, 2023 15:11

unlikelyzero commented Sep 11, 2023

View reviewed changes

scottbell reviewed Sep 11, 2023

View reviewed changes

e2e/tests/visual/notification.visual.spec.js Outdated Show resolved Hide resolved

unlikelyzero added 6 commits September 11, 2023 15:56

driveby: clean up order

b9ee114

restructure

3270695

add new suite now that i'ts hidden

cfb9273

use mission time everywhere possible

52fc78f

driveby

40728f3

rerun generatedata

aa4dbce

unlikelyzero commented Sep 11, 2023

View reviewed changes

comments

1a0d920

ozyx approved these changes Sep 11, 2023

View reviewed changes

lintfix

23fdb93

unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 11, 2023

github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 11, 2023

unlikelyzero merged commit 2a1064c into master Sep 11, 2023
9 checks passed

unlikelyzero deleted the stable-visual-tests branch September 11, 2023 23:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] Stabilize visual tests, remove appAction, and update pane buttons #7033

[CI] Stabilize visual tests, remove appAction, and update pane buttons #7033

unlikelyzero commented Sep 3, 2023 •

edited

Loading

codecov bot commented Sep 3, 2023 •

edited

Loading

deploysentinel bot commented Sep 3, 2023 •

edited

Loading

Test Case Results

unlikelyzero Sep 11, 2023

scottbell left a comment

unlikelyzero Sep 11, 2023

ozyx left a comment

ozyx Sep 11, 2023

unlikelyzero Sep 11, 2023

ozyx Sep 11, 2023

[CI] Stabilize visual tests, remove appAction, and update pane buttons #7033

[CI] Stabilize visual tests, remove appAction, and update pane buttons #7033

Conversation

unlikelyzero commented Sep 3, 2023 • edited Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

codecov bot commented Sep 3, 2023 • edited Loading

Codecov Report

deploysentinel bot commented Sep 3, 2023 • edited Loading

Current Playwright Test Results Summary

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

unlikelyzero Sep 11, 2023

Choose a reason for hiding this comment

scottbell left a comment

Choose a reason for hiding this comment

unlikelyzero Sep 11, 2023

Choose a reason for hiding this comment

ozyx left a comment

Choose a reason for hiding this comment

ozyx Sep 11, 2023

Choose a reason for hiding this comment

unlikelyzero Sep 11, 2023

Choose a reason for hiding this comment

ozyx Sep 11, 2023

Choose a reason for hiding this comment

unlikelyzero commented Sep 3, 2023 •

edited

Loading

codecov bot commented Sep 3, 2023 •

edited

Loading

deploysentinel bot commented Sep 3, 2023 •

edited

Loading