Filter values as a string not an object

[shefalijoshi]

Closes #7389

Describe your changes:

Use the value of a property for filtering metadata as a string if it is not undefined.

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes?
• Has this been smoke tested?
• Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
• Have you associated a milestone with this PR? Note: leave blank if unsure.
• Is this a breaking change to be called out in the release notes?
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Reviewer has tested changes by following the provided instructions?
• Changes appear not to be breaking changes?
• Appropriate automated tests included?
• Code style and in-line documentation are appropriate?

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (82fa4c1) 55.41% compared to head (a27f1d3) 55.41%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7448      +/-   ##
==========================================
- Coverage   55.41%   55.41%   -0.01%     
==========================================
  Files         671      671              
  Lines       26919    26920       +1     
  Branches     2614     2614              
==========================================
  Hits        14917    14917              
  Misses      11287    11287              
- Partials      715      716       +1     

Flag	Coverage Δ
e2e-full	49.02% <ø> (+0.08%)	⬆️
e2e-stable	59.15% <0.00%> (+0.19%)	⬆️
unit	48.38% <0.00%> (-0.04%)	⬇️

Files	Coverage Δ
.../plugins/timelist/inspector/FilteringComponent.vue	0.00% <ø> (ø)
src/plugins/plan/util.js	41.33% <0.00%> (-0.56%)	⬇️

... and 11 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fa4c1...a27f1d3. Read the comment docs.

[scottbell]

I'm not sure how to test this given the instructions on the ticket. Is Duration metadata? If so, it doesn't appear to be functioning correctly. I tried entering as 15:

which rendered no items:

Putting in the exact duration didn't seem to work either:

One other confusing thing: In edit mode, the time conductor bounds seem to be ignored? It makes adding filters rather confusing:

Screen.Recording.2024-02-01.at.4.03.57.PM.mov

[scottbell]

Having trouble testing this. We should make the testing instructions more clear with images, or a video. Also, we should add an e2e test.

[shefalijoshi]

I'm not sure how to test this given the instructions on the ticket. Is Duration metadata? If so, it doesn't appear to be functioning correctly. I tried entering as 15:

which rendered no items:

Putting in the exact duration didn't seem to work either:

One other confusing thing: In edit mode, the time conductor bounds seem to be ignored? It makes adding filters rather confusing:
Screen.Recording.2024-02-01.at.4.03.57.PM.mov

Duration can be metadata if you define it in the sourcemap or if it is part of an activity's property like this:
activity: {properties: {duration: 15}}

One other confusing thing: In edit mode, the time conductor bounds seem to be ignored? It makes adding filters rather confusing: This is working as designed.

We have a unit test for this already. We can add e2e test later.

I've added documentation for sourceMaps is here: fix-filter-metadata
Testing Instructions are updated here: #7389 (comment)

[scottbell]

Filtering on activities and with commas appeared to work:

as does meta-filtering:

with both filters in use, are they supposed to be OR'd together? That looks like the current implementation:

Also, PR doesn't look like it addresses @charlesh88's other issues, in particular:

We can't filter on values with "." in them - why not? If the user is trying to filter on a decimal number, they won't be able to.
The error messaging for the input is very poor and provides no concrete feedback of what the problem is or how to address it. This needs to be addressed from a text and layout standpoint.

[scottbell]

Looks like one can enter . now in filters too:

[scottbell]

LGTM