-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nested Flexible Layout direction problem #7637
Conversation
- More specific approach to CSS class application for column vs. row layouts. - Added layout direction CSS classing to `c-fl-container__frames-holder`. - Switched toolbar icon and titling for better parity with 'toggle' approach used elsewhere. - Cleaned up duped property def in mixin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, have a few comments and suggestions
- Updated e2e test. - New computed properties for layout direction. - CSS code cleanup.
All change requests addressed, changes pushed including an update to latest master. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7637 +/- ##
==========================================
- Coverage 56.68% 56.40% -0.29%
==========================================
Files 672 672
Lines 27183 27182 -1
Branches 2634 2635 +1
==========================================
- Hits 15409 15331 -78
- Misses 11447 11521 +74
- Partials 327 330 +3
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Couple things remaining:
- need to fix one failing test which looks to be due to changes in flexible layout behavior
- this PR needs a quick regression test
Closes #7635
c-fl-container__frames-holder
.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist