fix(#7791): tc form shouldn't submit bounds changes on dismiss #7792
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7792 +/- ##
==========================================
- Coverage 57.11% 56.83% -0.29%
==========================================
Files 674 674
Lines 27278 27276 -2
Branches 2668 2668
==========================================
- Hits 15579 15501 -78
- Misses 11359 11435 +76
Partials 340 340
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Let's make sure to add a test for this scenario with the native time conductor, but also an embedded independent time conductor in a display layout |
Working on it rn 👍 |
- update appAction for setting time conductor in fixed mode - add a11y to time conductor in fixed mode - update tests using `setTimeConductorBounds`
- wait for the rightmost image thumbnail to be in the viewport :D
| @@ -53,6 +53,9 @@ test.describe('Example Imagery Object', () => { | |||
| // Verify that the created object is focused | |||
| await expect(page.locator('.l-browse-bar__object-name')).toContainText(exampleImagery.name); | |||
| await page.getByLabel('Focused Image Element').hover({ trial: true }); | |||
|
|
|||
| // Wait for image thumbnail auto-scroll to complete | |||
| await expect(page.getByLabel('Image Thumbnail from').last()).toBeInViewport(); | |||
There was a problem hiding this comment.
here lies Can use the reset button to reset the image test flake (2022-2024) 🪦
Closes #7791
Describe your changes:
Reverts some changes that caused the
dismissaction on the fixed mode time conductor popup to submit changes. Does some "safe" refactoring of the component to make it slightly more maintainable.setTimeConductorBoundsto be more robustsetTimeConductorBoundsin existing testsAll Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist