-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't persist current tab when display is locked #7882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7882 +/- ##
==========================================
- Coverage 57.60% 57.41% -0.20%
==========================================
Files 676 676
Lines 27350 27351 +1
Branches 2684 2685 +1
==========================================
- Hits 15756 15703 -53
- Misses 11258 11311 +53
- Partials 336 337 +1
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ub.com/nasa/openmct into fix-persistent-tabs-immutable-displays
…ab displayed
Closes #7871
Describe your changes:
Check if a display is locked before saving current tab. The immutable aspect is handled by
openmct.objects.mutate
Add tests
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist