Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't persist current tab when display is locked #7882

Merged
merged 11 commits into from
Oct 11, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Oct 10, 2024

…ab displayed

Closes #7871

Describe your changes:

Check if a display is locked before saving current tab. The immutable aspect is handled by openmct.objects.mutate
Add tests

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@akhenry akhenry self-requested a review October 10, 2024 21:22
Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.41%. Comparing base (703186a) to head (30913e2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/tabs/components/TabsComponent.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7882      +/-   ##
==========================================
- Coverage   57.60%   57.41%   -0.20%     
==========================================
  Files         676      676              
  Lines       27350    27351       +1     
  Branches     2684     2685       +1     
==========================================
- Hits        15756    15703      -53     
- Misses      11258    11311      +53     
- Partials      336      337       +1     
Flag Coverage Δ
e2e-ci 62.38% <ø> (+<0.01%) ⬆️
e2e-full 41.81% <ø> (-12.16%) ⬇️
unit 49.28% <0.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
src/ui/layout/BrowseBar.vue 40.33% <ø> (-3.37%) ⬇️
src/plugins/tabs/components/TabsComponent.vue 37.59% <0.00%> (-0.29%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703186a...30913e2. Read the comment docs.

@akhenry akhenry added this to the Build 9 RC11 milestone Oct 11, 2024
@akhenry akhenry enabled auto-merge (squash) October 11, 2024 22:54
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 11, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 11, 2024
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 11, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 11, 2024
@akhenry akhenry merged commit 2b86739 into master Oct 11, 2024
21 checks passed
@akhenry akhenry deleted the fix-persistent-tabs-immutable-displays branch October 11, 2024 23:17
davetsay added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabbed displays trigger persistence when navigating away
2 participants