Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure integration #1066

Merged
merged 19 commits into from
Jul 12, 2023
Merged

Azure integration #1066

merged 19 commits into from
Jul 12, 2023

Conversation

InquestGeronimo
Copy link
Contributor

Adding an integration for launching an Azure instance with DeepSparse image similar to the AWS and GCP marketplace integrations.

@InquestGeronimo InquestGeronimo self-assigned this Jun 13, 2023
bfineran
bfineran previously approved these changes Jun 14, 2023
Copy link
Contributor

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, great job breaking the script into clean helper functions.
Including a small diagram in the README may be nice to make it a bit more clear 1) what is provisioned in azure 2) how the user interacts with it

@mgoin mgoin merged commit e10bbd1 into main Jul 12, 2023
@mgoin mgoin deleted the azure branch July 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants