Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin minimum dim size for random data to 1 #1086

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Pin minimum dim size for random data to 1 #1086

merged 1 commit into from
Jun 21, 2023

Conversation

KSGulin
Copy link
Contributor

@KSGulin KSGulin commented Jun 21, 2023

Models with dynamic input dims (e.g. batch size) will have a dim_size of 0, resulting in an empty array generated by generate_random_inputs(). This update simply sets the minimum dim_size to 1.

@KSGulin KSGulin requested a review from a team June 21, 2023 08:39
@KSGulin KSGulin self-assigned this Jun 21, 2023
@KSGulin KSGulin requested review from ohaijen, anmarques and dsikka and removed request for a team June 21, 2023 08:39
@KSGulin KSGulin merged commit 7aa8ac4 into main Jun 21, 2023
@KSGulin KSGulin deleted the min_random_data_shape branch June 21, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@shubhra shubhra shubhra approved these changes

@ohaijen ohaijen Awaiting requested review from ohaijen ohaijen was automatically assigned from neuralmagic/machine-learning

@anmarques anmarques Awaiting requested review from anmarques anmarques was automatically assigned from neuralmagic/machine-learning

@dsikka dsikka Awaiting requested review from dsikka dsikka was automatically assigned from neuralmagic/machine-learning

Assignees

@KSGulin KSGulin

Labels
mle-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KSGulin @shubhra @bfineran