[TextGeneration][Bug] Fix timer #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
suggested changes
Oct 3, 2023
bfineran
reviewed
Oct 3, 2023
Comment on lines
+348
to
+349
| with self.new_timer_context(total_inference=False) as timer: | ||
| return timer |
There was a problem hiding this comment.
is this tested? just want to make sure it won't exit the context and leave with current not set (even if the timer object still exists)
There was a problem hiding this comment.
This PR fixes my test case within gradio so I'll accept!
There was a problem hiding this comment.
Right, I'm sure it will work, only question I had is if the current that is created will actually live beyond the context in this function
There was a problem hiding this comment.
Good call, this is worth investigating in a followup
bfineran
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this ticket: https://app.asana.com/0/1205229323407165/1205618233879512/f
Tested locally with gradio/non-gradio examples