Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pydantic support to v2 #1645

Merged
merged 10 commits into from
Apr 30, 2024
Merged

Bump pydantic support to v2 #1645

merged 10 commits into from
Apr 30, 2024

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Apr 26, 2024 •
edited
Loading

The changes include:

  • Using bump-pydantic to update basic usages to v2
  • Update missing types
  • Set defaults where needed
  • Use pydantic v1 for Numpy Schemas
  • Deprecate Haystack
  • Update fastapi
  • Update TestClient usage as a consequence of fastapi update

Test: Ran make test and make test_integrations

@rahul-tuli rahul-tuli changed the title [WIP] Bump pydantic Bump pydantic support to v2 Apr 29, 2024
@rahul-tuli rahul-tuli self-assigned this Apr 29, 2024
@rahul-tuli rahul-tuli merged commit ee0be47 into main Apr 30, 2024
13 checks passed
@rahul-tuli rahul-tuli deleted the bump-pydantic branch April 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbogunowicz dbogunowicz dbogunowicz approved these changes

@bfineran bfineran bfineran approved these changes

@dsikka dsikka Awaiting requested review from dsikka

@Satrat Satrat Awaiting requested review from Satrat

@horheynm horheynm Awaiting requested review from horheynm

Assignees

@rahul-tuli rahul-tuli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul-tuli @bfineran @dbogunowicz