-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #410
Refactoring #410
Conversation
Can you split it into 2 PRs? |
c810d69
to
dab9e99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR has some simple refactoring (I guess automated or semi-automated), fixing some issues with tests and removal of some code duplicates.
The automated refactoring together is ugly diff makes it hard to spot the meaningful changes (and it does not make much sense to check the automated refactored code).
Maybe, can you provide a list of those changes, comment them or split the PR even more?
44ae85a
to
7af386e
Compare
I reverted changes in python tests and code duplication changes. Now only refactoring is here.
|
Thank you! With a quick look seems to be good. We would need to run the performance tests before the release though. Please merge pull request with the "squash and merge" option, so it would be a single commit. |
d871f58
to
10e75a2
Compare
10e75a2
to
788a7ea
Compare
Squashed changes in one commit. Performance tests do not show any regress. |
Added a new method to replace the deleted elements and tests
Refactoring:
Edit:
I left only refactoring