Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HierarchicalNSW::indexFileSize() function for precise memory footprint control #427

Merged
merged 1 commit into from
May 13, 2023
Merged

Add HierarchicalNSW::indexFileSize() function for precise memory footprint control #427

merged 1 commit into from
May 13, 2023

Conversation

drons
Copy link
Contributor

@drons drons commented Dec 5, 2022

No description provided.

@yurymalkov
Copy link
Member

Hi @drons,
Thank for the PR! We will check it and merge it after we prepare the release (should happen soon).

dyashuni
dyashuni reviewed May 7, 2023
View reviewed changes
python_bindings/bindings.cpp Outdated
@@ -218,6 +218,9 @@ class Index {
this->num_threads_default = num_threads;
}

void indexFileSize() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to return an index size here

size_t indexFileSize() const {
    return appr_alg->indexFileSize();
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

dyashuni
dyashuni requested changes May 7, 2023
View reviewed changes
Copy link
Contributor

@dyashuni dyashuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, please add a small change

@yurymalkov
Copy link
Member

Thank you for the PR!

@yurymalkov yurymalkov merged commit cd844b5 into nmslib:develop May 13, 2023
@drons
Copy link
Contributor Author

drons commented May 13, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyashuni dyashuni dyashuni requested changes

@yurymalkov yurymalkov yurymalkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drons @yurymalkov @dyashuni