Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of project structure #432

Merged
merged 5 commits into from
Jan 15, 2023
Merged

Refactoring of project structure #432

merged 5 commits into from
Jan 15, 2023

Conversation

dyashuni
Copy link
Contributor

  • Refactoring of project structure
    • split tests to cpp and python
    • keep in examples folder only examples
    • move tests to separate folder
  • Add page with examples and new example files
  • Update Readme

yurymalkov
yurymalkov approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@yurymalkov yurymalkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. There is a misprint in readme's code and few suggestions.

README.md Outdated Show resolved Hide resolved
examples/EXAMPLES.md Outdated Show resolved Hide resolved
examples/EXAMPLES.md Show resolved Hide resolved
examples/EXAMPLES.md Outdated Show resolved Hide resolved
@dyashuni dyashuni merged commit d86f8f9 into nmslib:develop Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurymalkov yurymalkov yurymalkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyashuni @yurymalkov