This repository was archived by the owner on Apr 6, 2023. It is now read-only.
chore: reverse target/from in eslint rule #3280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
I think our internal lint rule was enforcing the opposite of what we meant to though I may have misunderstood the intent. But we are, I think, violating it here:
framework/packages/nuxt3/src/core/nuxt.ts
Lines 5 to 8 in aece351
This PR is an initial stab meant to highlight the issue - we either need to:
cc: @clarkdo