-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make processortest
into its own module
#11218
Comments
@wildum will work on this one :) |
The trick is that processorhelper is part of the processor module and it uses processortest. I believe that in order to have processortest in its own module, we would need to also have processorhelper in its own module. |
Hm, cyclic dependencies between modules should not be a problem for Go as far as I am aware; they are not great, but since this is only meant to be used in tests and we can move those around easily I am not worried about creating the cycle, we can get rid of it easily |
I believe that Go does not allow cycle dependencies between modules. I tested and I got the error "import cycle not allowed" |
As I understand it, Go does not allow cycle dependencies between packages but it does allow them between modules.
Maybe you can file the PR so I can take a look? Tackling this issue shouldn't need moving code around, so I am confused as to how this error could happen |
Apologies about my previous statements, my implementation was wrong, you are correct :) |
This PR is putting the processortest pkg in its own module as requested in open-telemetry#11216 Fixes open-telemetry#11218
No description provided.
The text was updated successfully, but these errors were encountered: