Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make processortest into its own module #11218

Closed
Tracked by #11216
mx-psi opened this issue Sep 19, 2024 · 6 comments · Fixed by #11229
Closed
Tracked by #11216

Make processortest into its own module #11218

mx-psi opened this issue Sep 19, 2024 · 6 comments · Fixed by #11229

Comments

@mx-psi
Copy link
Member

mx-psi commented Sep 19, 2024

No description provided.

@mx-psi
Copy link
Member Author

mx-psi commented Sep 19, 2024

@wildum will work on this one :)

@wildum
Copy link
Contributor

wildum commented Sep 19, 2024

The trick is that processorhelper is part of the processor module and it uses processortest. I believe that in order to have processortest in its own module, we would need to also have processorhelper in its own module.
Or am I missing something? @mx-psi

@mx-psi
Copy link
Member Author

mx-psi commented Sep 19, 2024

Hm, cyclic dependencies between modules should not be a problem for Go as far as I am aware; they are not great, but since this is only meant to be used in tests and we can move those around easily I am not worried about creating the cycle, we can get rid of it easily

@wildum
Copy link
Contributor

wildum commented Sep 19, 2024

I believe that Go does not allow cycle dependencies between modules. I tested and I got the error "import cycle not allowed"

@mx-psi
Copy link
Member Author

mx-psi commented Sep 20, 2024

I believe that Go does not allow cycle dependencies between modules.

As I understand it, Go does not allow cycle dependencies between packages but it does allow them between modules.

I tested and I got the error "import cycle not allowed"

Maybe you can file the PR so I can take a look? Tackling this issue shouldn't need moving code around, so I am confused as to how this error could happen

@wildum
Copy link
Contributor

wildum commented Sep 20, 2024

Apologies about my previous statements, my implementation was wrong, you are correct :)
The PR is open: #11229

bogdandrutu pushed a commit that referenced this issue Oct 15, 2024
This PR is putting the processortest pkg in its own module as requested
in
#11216

Fixes #11218
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this issue Nov 21, 2024
This PR is putting the processortest pkg in its own module as requested
in
open-telemetry#11216

Fixes open-telemetry#11218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants