Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update required go version to build in CONTRIBUTING.md #2717

Closed
fletcm opened this issue Mar 16, 2021 · 1 comment
Closed

update required go version to build in CONTRIBUTING.md #2717

fletcm opened this issue Mar 16, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@fletcm
Copy link
Contributor

fletcm commented Mar 16, 2021

Describe the bug
The bug is that CONTRIBUTING.md lists the required version of golang to build the project as 1.14, however make lint fails with this version.

Steps to reproduce
set your local go version to 1.14
make lint fails (output below)
set your local go version to 1.16
make lint now works

What did you expect to see?
Expected it to succeed.

What did you see instead?

$ make lint
golangci-lint run --allow-parallel-runners
WARN [runner] Can't run linter goanalysis_metalinter: S1004: failed prerequisites: [([email protected]/collector/cmd/schemagen/schemagen [go.opentelemetry.io/collector/cmd/schemagen/schemagen.test], [email protected]/collector/cmd/schemagen/schemagen [go.opentelemetry.io/collector/cmd/schemagen/schemagen.test]): analysis skipped: errors in package: [/apps/opentelemetry-collector/cmd/schemagen/schemagen/cli_all_test.go:34:15: t.TempDir undefined (type *testing.T has no field or method TempDir) /apps/opentelemetry-collector/cmd/schemagen/schemagen/cli_single_test.go:75:15: t.TempDir undefined (type *testing.T has no field or method TempDir)]] 
WARN [runner] Can't run linter unused: buildir: analysis skipped: errors in package: [/apps/opentelemetry-collector/cmd/schemagen/schemagen/cli_all_test.go:34:15: t.TempDir undefined (type *testing.T has no field or method TempDir) /apps/opentelemetry-collector/cmd/schemagen/schemagen/cli_single_test.go:75:15: t.TempDir undefined (type *testing.T has no field or method TempDir)] 
ERRO Running error: buildir: analysis skipped: errors in package: [/apps/opentelemetry-collector/cmd/schemagen/schemagen/cli_all_test.go:34:15: t.TempDir undefined (type *testing.T has no field or method TempDir) /apps/opentelemetry-collector/cmd/schemagen/schemagen/cli_single_test.go:75:15: t.TempDir undefined (type *testing.T has no field or method TempDir)] 
make: *** [lint] Error 3

What version did you use?
Version: upstream/main as of yesterday

What config did you use?
Config: (e.g. the yaml config file)

Environment
OS: Mac OSX Mojave 10.14.6

Additional context
The method it is complaining about was introduced in go 1.15. Just need to update CONTRIBUTING.md to reflect this, unless there is a reason to change the code instead to get back compatibility with 1.14.

@bogdandrutu
Copy link
Member

I think this is done since I merged that PR. Please reopen if that is not the case

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
* relocate agent codebase into pkg/signalfx-agent

* update monitorcodegen groupMetricsMap to not need fmt change

* pkg/signalfx-agent noop lint targets

* pkg/signalfx-agent: clarify initial base

* update dependabot for pkg/signalfx-agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants