Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a comment in the class description that code "inspired/copied" from and a link to the code. #4521

Closed
jpkrohling opened this issue Dec 8, 2021 · 0 comments · Fixed by #4531
Closed

Add a comment in the class description that code "inspired/copied" from and a link to the code. #4521

jpkrohling opened this issue Dec 8, 2021 · 0 comments · Fixed by #4531
Assignees
@jpkrohling

Comments

@jpkrohling
Copy link
Member

Add a comment in the class description that code "inspired/copied" from and a link to the code.

Originally posted by @bogdandrutu in #4423 (comment)
@jpkrohling jpkrohling self-assigned this Dec 8, 2021
@jpkrohling jpkrohling mentioned this issue Dec 8, 2021
Merged
jpkrohling added a commit to jpkrohling/opentelemetry-collector that referenced this issue Dec 9, 2021
@jpkrohling
Credit grpc-ecosystem/go-grpc-middleware for WrappedServerStream
c21fad8 
Fixes open-telemetry#4521

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling mentioned this issue Dec 9, 2021
Merged
bogdandrutu pushed a commit that referenced this issue Dec 10, 2021
@jpkrohling
Credit grpc-ecosystem/go-grpc-middleware for WrappedServerStream (#4531)
02cab16 
Fixes #4521

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Credit grpc-ecosystem/go-grpc-middleware for WrappedServerStream jpkrohling/opentelemetry-collector
1 participant
@jpkrohling