Add test for DefaultHTTPInterceptor

[jpkrohling]

For some reason, a test for configauth.DefaultHTTPInterceptor is currently missing. There should definitely be a test for it.

[jpkrohling]

This code has been moved to this place:

opentelemetry-collector/config/confighttp/confighttp.go

Lines 317 to 327 in 84b3706

	func authInterceptor(next http.Handler, authenticate configauth.AuthenticateFunc) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
	ctx, err := authenticate(r.Context(), r.Header)
	if err != nil {
	http.Error(w, http.StatusText(http.StatusUnauthorized), http.StatusUnauthorized)
	return
	}
	next.ServeHTTP(w, r.WithContext(ctx))
	})
	}

[josephwoodward]

I'm happy to pick this one up?

[jpkrohling]

It is yours!

[jpkrohling]

@josephwoodward, do you need help moving forward with this?

[josephwoodward]

@jpkrohling I had a quick look, but didn't get as much time over Christmas as I was hoping to. Now everything is settling down again I can get it sorted.

Whilst having a quick look at it I noticed the TestServerAuth test covers the happy path of the default handler, so I my understanding is this issue is to cover if authenticate returns an error, is that correct?

[jpkrohling]

so I my understanding is this issue is to cover if authenticate returns an error, is that correct?

Yes, that seems right. Looks like the happy path is covered.

[josephwoodward]

@jpkrohling Great, I've raised a PR here

[josephwoodward]

This issue can now be closed 👍

[bogdandrutu]

Thanks @josephwoodward