Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement default client authenticators, where functions can be overridden #4557

Closed
Tracked by #4534
jpkrohling opened this issue Dec 15, 2021 · 7 comments · Fixed by #4837
Closed
Tracked by #4534

Implement default client authenticators, where functions can be overridden #4557

jpkrohling opened this issue Dec 15, 2021 · 7 comments · Fixed by #4837
Assignees
@jpkrohling

Comments

@jpkrohling
Copy link
Member

No description provided.

@jpkrohling jpkrohling mentioned this issue Dec 15, 2021
Closed
2 tasks
@jpkrohling jpkrohling self-assigned this Dec 15, 2021
@jpkrohling
Copy link
Member Author

@MovieStoreGuy, would you like to work on this? If you are interested, start only after the gRPC one is merged, as it should serve as the model for this.

@MovieStoreGuy
Copy link
Contributor

@MovieStoreGuy, would you like to work on this? If you are interested, start only after the gRPC one is merged, as it should serve as the model for this.

I am interested, for sure :D
Do you have a link to the gRPC branch?

@jpkrohling
Copy link
Member Author

Hold on a bit on this, there was a change in plans for this. See #4582 for more info.

@jpkrohling
Copy link
Member Author

@MovieStoreGuy, the PR #4558 was merged and can be used as a model for this one here. Would you like to work on it?

@jpkrohling
Copy link
Member Author

@MovieStoreGuy, are you still interested in this one? I have it on my queue and can start working on it right away if you have enough on your queue.

jpkrohling added a commit to jpkrohling/opentelemetry-collector that referenced this issue Feb 10, 2022
@jpkrohling
Implement default client authenticators
900f4c5 
Similar to open-telemetry#4558, this allows client authenticators to be created without having to implement all the functions from the ClientAuthenticator interface.

This is non-breaking change.

Fixes open-telemetry#4557

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling added a commit to jpkrohling/opentelemetry-collector that referenced this issue Feb 10, 2022
@jpkrohling
Implement default client authenticators
c00f62b 
Similar to open-telemetry#4558, this allows client authenticators to be created without having to implement all the functions from the ClientAuthenticator interface.

This is non-breaking change.

Fixes open-telemetry#4557

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling mentioned this issue Feb 10, 2022
Merged
@MovieStoreGuy
Copy link
Contributor

Sorry, had completely missed this. I can add it to my queue of work :)

@jpkrohling
Copy link
Member Author

Don't worry. I had this also on my queue and ended up sending #4837 for it.

jpkrohling added a commit to jpkrohling/opentelemetry-collector that referenced this issue Feb 17, 2022
@jpkrohling
Implement default client authenticators
3724991 
Similar to open-telemetry#4558, this allows client authenticators to be created without having to implement all the functions from the ClientAuthenticator interface.

This is non-breaking change.

Fixes open-telemetry#4557

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling added a commit to jpkrohling/opentelemetry-collector that referenced this issue Mar 10, 2022
@jpkrohling
Implement default client authenticators
5f33f0f 
Similar to open-telemetry#4558, this allows client authenticators to be created without having to implement all the functions from the ClientAuthenticator interface.

This is non-breaking change.

Fixes open-telemetry#4557

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
codeboten pushed a commit that referenced this issue Mar 11, 2022
@jpkrohling
Implement default client authenticators (#4837)
5ee716f 
* Implement default client authenticators

Similar to #4558, this allows client authenticators to be created without having to implement all the functions from the ClientAuthenticator interface.

This is non-breaking change.

Fixes #4557

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this issue Jun 7, 2022
@jpkrohling @Nicholaswang
Implement default client authenticators (open-telemetry#4837)
61df08d 
* Implement default client authenticators

Similar to open-telemetry#4558, this allows client authenticators to be created without having to implement all the functions from the ClientAuthenticator interface.

This is non-breaking change.

Fixes open-telemetry#4557

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement default client authenticators jpkrohling/opentelemetry-collector
2 participants
@jpkrohling @MovieStoreGuy