Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configtls/README.md gives wrong default max TLS version #5430

Closed
pureklkl opened this issue May 26, 2022 · 0 comments
Closed

configtls/README.md gives wrong default max TLS version #5430

pureklkl opened this issue May 26, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@pureklkl
Copy link
Contributor

Describe the bug
The default max TLS version in readme is 1.3 but looking at the code
https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configtls/configtls.go#L183
which called method convertVersion at
https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configtls/configtls.go#L242
It gives default to be 1.2.

Steps to reproduce
If you let max_version be empty and try to talk to the collector with TLSv1.3, you will see
client offered only unsupported versions: [304]

What did you expect to see?
The default max version should be tls1.3.

What did you see instead?
The default max version is tls1.2.

What version did you use?
v0.52.0

What config did you use?
Config: (e.g. the yaml config file)

Environment
otel/opentelemetry-collector-contrib docker image

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants