-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder tool name is inconsistent #5581
Comments
|
@jpkrohling WDYT if I standardize all the names to |
It has to be |
Hmm, I was suggesting |
Right, but the builder isn't at the same level as "otel-collector", as it's a tool that builds "otelcol" binaries. |
OK, I'll knock up a PR to standardize on |
Update the builder to consistently use "ocb" in the name of the command, version and configuration file. This fixes open-telemetry#5581. Signed-off-by: James Peach <[email protected]>
Update the builder to consistently use "ocb" in the name of the command, version and configuration file. This fixes open-telemetry#5581. Signed-off-by: James Peach <[email protected]>
Update the builder to consistently use "ocb" in the name of the command, version. To avoid needing to be forward compatible with configuration file names, move the configuration file name from a flag to a command argument, while deprecating and preserving the original behavior. This fixes open-telemetry#5581. Signed-off-by: James Peach <[email protected]>
Update the builder to consistently use "ocb" in the name of the command, version. To avoid needing to be forward compatible with configuration file names, move the configuration file name from a flag to a command argument, while deprecating and preserving the original behavior. This fixes open-telemetry#5581. Signed-off-by: James Peach <[email protected]>
Update the builder to consistently use "ocb" in the name of the command, version. Since the builder does not expand environment variables in the config file pathname, the default value for `--config` does not work, so we can make this flag required so that users don't silently build an inoperative collector. This fixes open-telemetry#5581. Signed-off-by: James Peach <[email protected]>
Update the builder to consistently use "ocb" in the name of the command, version. Since the builder does not expand environment variables in the config file pathname, the default value for `--config` does not work, so we can make this flag required so that users don't silently build an inoperative collector. This fixes #5581. Signed-off-by: James Peach <[email protected]>
Describe the bug
The builder tool is alternately named
ocb
,builder
oropentelemetry-collector-builder
, depending on where you look.Steps to reproduce
Download a release binary, e.g. ocb_0.54.0_darwin_amd64
What did you expect to see?
A consistent name for the builder tool.
What did you see instead?
The release process names the tool
ocb
, the subcommand name isbuilder
and the version help calls itopentelemetry-collector-builder
. And I guess the config file implies the tool would beotelcol-builder
.What version did you use?
Version: 0.54.0
What config did you use?
Config: N/A
Environment
OS: Darwin
Compiler(if manually compiled): N/A
The text was updated successfully, but these errors were encountered: