-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdata/pcommon : export NewSliceFromRaw #5617
Comments
ldb
changed the title
pdata/pcommon : export NewSlice and NewSliceFromRaw
pdata/pcommon : export NewSliceFromRaw
Jul 3, 2022
pinging @dmitryax |
@ldb if you are unavailable I can take it |
Hey @dmitryax and @TylerHelmuth, sorry I only now saw the response here. Would've loved to open a PR for this, but now there is no need I see :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Right now, the apparently only way to create slices Values and adding them to a span's attributes is pretty unergonomic:
This could be made much easier by exporting
pcommon.NewSliceFromRaw()
in the same way thatpcommon.NewMapFromRaw()
is already exported.Describe the solution you'd like
Export
internal.NewSliceFromRaw
to make it easier to create slices to be used as attribute values.The text was updated successfully, but these errors were encountered: