Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[componentstatus] Continue DataType rename #11313

Merged

Conversation

TylerHelmuth
Copy link
Member

Description

Continues the DataType rename process for NewInstanceIDWithPipelineIDs, AllPipelineIDsWithPipelineIDs, and WithPipelineIDs.

Link to tracking issue

Related to #9429

Verified

This commit was signed with the committer’s verified signature.
TylerHelmuth Tyler Helmuth
@TylerHelmuth TylerHelmuth requested a review from a team as a code owner September 30, 2024 22:03

Verified

This commit was signed with the committer’s verified signature.
TylerHelmuth Tyler Helmuth

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@TylerHelmuth TylerHelmuth requested a review from mx-psi September 30, 2024 22:08
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.62%. Comparing base (6412988) to head (16069a5).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
component/componentstatus/instance.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11313      +/-   ##
==========================================
+ Coverage   91.49%   91.62%   +0.12%     
==========================================
  Files         424      424              
  Lines       20240    20212      -28     
==========================================
  Hits        18519    18519              
+ Misses       1344     1316      -28     
  Partials      377      377              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi merged commit e69f2f3 into open-telemetry:main Oct 1, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 1, 2024
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024

Verified

This commit was signed with the committer’s verified signature.
jackgopack4 John L. Peterson (Jack)
#### Description
Continues the DataType rename process for
`NewInstanceIDWithPipelineIDs`, `AllPipelineIDsWithPipelineIDs`, and
`WithPipelineIDs`.

#### Link to tracking issue
Related to
open-telemetry#9429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants