update time period before removing an unmaintained component #11664
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reviewing the 6 month period, the period seems too long to get feedback on whether an unmaintained component should be removed. I'm proposing shortening it to 3 months. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
TylerHelmuth
approved these changes
Nov 12, 2024
bogdandrutu
approved these changes
Nov 12, 2024
mx-psi
approved these changes
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11664 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 440 440
Lines 23754 23754
=======================================
Hits 21755 21755
Misses 1627 1627
Partials 372 372 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Nov 13, 2024
evan-bradley
approved these changes
Nov 13, 2024
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…lemetry#11664) After reviewing the 6 month period, the period seems too long to get feedback on whether an unmaintained component should be removed. I'm proposing shortening it to 3 months. --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the 6 month period, the period seems too long to get feedback on whether an unmaintained component should be removed. I'm proposing shortening it to 3 months.