-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication processor 4/4 - Add configauth to configgrpc #1810
Authentication processor 4/4 - Add configauth to configgrpc #1810
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1810 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 277 278 +1
Lines 16489 16503 +14
=======================================
+ Hits 15052 15065 +13
- Misses 1006 1007 +1
Partials 431 431
Continue to review full report at Codecov.
|
c1081a6
to
0c61c84
Compare
@jpkrohling thank you for splitting into smaller PRs. |
Please rebase |
0c61c84
to
e893ac4
Compare
Rebased and re-tested, confirming that it still works :-) |
@jpkrohling can you make codecov happy? 👍 |
5c2247d
to
166158a
Compare
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
166158a
to
4b43268
Compare
PR updated: new test, rebased and squashed. |
) * Removed different types of Detectors for Resources. This change simplifies different types of collectors into one list. The order of this list determines how they are applied. Defaults are applied when the user does not supply any detectors. To achieve default behavior and additional behavior a DefaultDetectors struct has been created * missed prometheus test. * Changed behavior around WithDetectors(nil) Added examples of use of WithDetectors. * Added NoOp example * Changed test to reflect acutal default case This changes because WithDetector() no longer is the same as not using WithDetector() * Unexports the noOp detector * Updated changelog * Fixes to spelling mistakes. * Added NewEmptyResouce and unexported builtin detectors * Fix for prometheus example * Resource has two Rs I need to get a new R key it seems. Co-authored-by: Sam Xie <[email protected]> * Replaced NewEmptyResource() with New() * Fix test function name * Comment fixups. * Apply suggestions from code review Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Sam Xie <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
…y#1810) Bumps [boto3](https://github.com/boto/boto3) from 1.24.37 to 1.24.38. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.37...1.24.38) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description: Added the configauth to configgrpc. Split from #1728.
This PR is based on top of #1809.
Link to tracking Issue: Part of the solution for #1424.
Testing: manual and unit tests.
Documentation: none.
Signed-off-by: Juraci Paixão Kröhling [email protected]