Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication processor 4/4 - Add configauth to configgrpc #1810

Conversation

jpkrohling
Copy link
Member

Description: Added the configauth to configgrpc. Split from #1728.

This PR is based on top of #1809.

Link to tracking Issue: Part of the solution for #1424.

Testing: manual and unit tests.

Documentation: none.

Signed-off-by: Juraci Paixão Kröhling [email protected]

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1810 into master will increase coverage by 0.00%.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1810   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         277      278    +1     
  Lines       16489    16503   +14     
=======================================
+ Hits        15052    15065   +13     
- Misses       1006     1007    +1     
  Partials      431      431           
Impacted Files Coverage Δ
config/configauth/authenticator.go 100.00% <ø> (ø)
config/configauth/context.go 100.00% <ø> (ø)
config/configauth/oidc_authenticator.go 98.03% <ø> (ø)
config/configgrpc/configgrpc.go 98.76% <80.00%> (-1.24%) ⬇️
config/configauth/configauth.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 89.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab0c56...4b43268. Read the comment docs.

@jpkrohling jpkrohling force-pushed the jpkrohling/authentication-processor-part-4 branch from c1081a6 to 0c61c84 Compare September 18, 2020 09:01
@tigrannajaryan
Copy link
Member

@jpkrohling thank you for splitting into smaller PRs.

@bogdandrutu
Copy link
Member

Please rebase

@jpkrohling jpkrohling force-pushed the jpkrohling/authentication-processor-part-4 branch from 0c61c84 to e893ac4 Compare September 29, 2020 07:55
@jpkrohling
Copy link
Member Author

jpkrohling commented Sep 29, 2020

Rebased and re-tested, confirming that it still works :-)

@bogdandrutu
Copy link
Member

@jpkrohling can you make codecov happy? 👍

@jpkrohling jpkrohling force-pushed the jpkrohling/authentication-processor-part-4 branch from 5c2247d to 166158a Compare October 1, 2020 09:03
@jpkrohling jpkrohling force-pushed the jpkrohling/authentication-processor-part-4 branch from 166158a to 4b43268 Compare October 1, 2020 09:13
@jpkrohling
Copy link
Member Author

PR updated: new test, rebased and squashed.

@bogdandrutu bogdandrutu merged commit c3fe0d0 into open-telemetry:master Oct 1, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
)

* Removed different types of Detectors for Resources.

This change simplifies different types of collectors into one list. The
order of this list determines how they are applied.  Defaults are
applied when the user does not supply any detectors.  To achieve
default behavior and additional behavior a DefaultDetectors struct has been
created

* missed prometheus test.

* Changed behavior around WithDetectors(nil)

Added examples of use of WithDetectors.

* Added NoOp example

* Changed test to reflect acutal default case

This changes because WithDetector() no longer is the same as not using WithDetector()

* Unexports the noOp detector

* Updated changelog

* Fixes to spelling mistakes.

* Added NewEmptyResouce and unexported builtin detectors

* Fix for prometheus example

* Resource has two Rs

I need to get a new R key it seems.

Co-authored-by: Sam Xie <[email protected]>

* Replaced NewEmptyResource() with New()

* Fix test function name

* Comment fixups.

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <[email protected]>

Co-authored-by: Sam Xie <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1810)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.37 to 1.24.38.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.37...1.24.38)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants