Add "compression" option to otlphttp exporter #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Feb 17, 2021
9795f46
to
c77bb28
Compare
bogdandrutu
previously requested changes
Feb 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #2502 +/- ##
==========================================
- Coverage 91.76% 91.73% -0.03%
==========================================
Files 266 266
Lines 15111 15136 +25
==========================================
+ Hits 13866 13885 +19
- Misses 866 869 +3
- Partials 379 382 +3
Continue to review full report at Codecov.
|
c77bb28
to
c7e7137
Compare
|
Don't merge yet, I need to check all contrib exporters to make sure they are not affected. |
bogdandrutu
reviewed
Feb 17, 2021
bogdandrutu
reviewed
Feb 17, 2021
bogdandrutu
reviewed
Feb 17, 2021
c7e7137
to
5764757
Compare
5764757
to
bf47d96
Compare
|
OK, changed the implementation to make "compression" option opt-in for exporters. It was dangerous to enable for all http exporters since some exporter already do their own compression. See updated PR description. |
bf47d96
to
965f750
Compare
|
contrib_tests failure is expected. Will need to fix after this is merged. |
|
Now ready for review. |
jpkrohling
reviewed
Feb 17, 2021
22cbd82
to
982a57e
Compare
jpkrohling
approved these changes
Feb 17, 2021
982a57e
to
360d81f
Compare
This was referenced Mar 15, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#2502) Bumps [go.etcd.io/etcd/client/v2](https://github.com/etcd-io/etcd) from 2.305.6 to 2.305.7. - [Release notes](https://github.com/etcd-io/etcd/releases) - [Changelog](https://github.com/etcd-io/etcd/blob/main/Dockerfile-release.amd64) - [Commits](etcd-io/etcd@client/v2.305.6...client/v2.305.7) --- updated-dependencies: - dependency-name: go.etcd.io/etcd/client/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
…etry#2502) * Upgrade compiler in CI * Backport abseil fix for clang-15. * More backport for clang-15 * Missed backport bits. * Fixed a new warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of "compression" option is empty and results in no compression,
which is the same as the old behavior. You can also specify "compression: gzip"
which will result in gzip encoding of outgoing http requests.