Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to pass command arguments with make run #2877

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Apr 1, 2021

make run is a useful command, but there is no way to pass extra command arguments. This commit adds a way to do that with RUN_ARGS env variable

`make run` is useful target but there is no way to pass extra command arguments. This commit adds a way to do that with RUN_ARGS env variable
@dmitryax dmitryax requested a review from a team April 1, 2021 17:43
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2877 (68dfe6d) into main (a08a650) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2877   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         286      286           
  Lines       15088    15088           
=======================================
  Hits        13847    13847           
  Misses        849      849           
  Partials      392      392           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08a650...68dfe6d. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 4dcd2b8 into open-telemetry:main Apr 1, 2021
pjanotti pushed a commit to pjanotti/opentelemetry-service that referenced this pull request Apr 6, 2021
…ry#2877)

`make run` is useful target but there is no way to pass extra command arguments. This commit adds a way to do that with RUN_ARGS env variable
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants