Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test failure logging for TestBallastMemory #3240

Merged
merged 1 commit into from
May 20, 2021

Conversation

jpkrohling
Copy link
Member

This change improves the failure message for the TestBallastMemory. While this won't solve the problem, it will help understand if we are barely above the limit, or if the test went considerably above the max.

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling jpkrohling requested a review from a team May 20, 2021 12:30
@jpkrohling jpkrohling requested a review from owais May 20, 2021 12:30
@jpkrohling
Copy link
Member Author

@owais, could you please review this one? You seem to have worked on this part in the past. I'm not sure I understand all that is happening in this test. For instance: is there a relation between the ballast size and the RSS? Is the max RSS here an absolute value, or should we fail only when the RSS is, say, 10% above Max RSS?

@jpkrohling
Copy link
Member Author

Luckily, the test failed, which allows us to test the PR :-)

2021/05/20 12:34:56 Agent running, pid=7398
    assertion_compare.go:342: 
        	Error Trace:	e2e_test.go:87
        	Error:      	"71" is not less than or equal to "70"
        	Test:       	TestBallastMemory
        	Messages:   	[]

@tigrannajaryan tigrannajaryan merged commit 7d3d9ca into open-telemetry:main May 20, 2021
dashpole pushed a commit to dashpole/opentelemetry-collector that referenced this pull request Jun 14, 2021
This change improves the failure message for the TestBallastMemory. While this won't solve the problem, it will help understand if we are barely above the limit, or if the test went considerably above the max.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants