Move BigEndian helper functions in tracetranslator to an internal package #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llector into 3226-Hide_tracetranslator merge changelog
Co-authored-by: Anthony Mirabella <[email protected]>
bogdandrutu
approved these changes
May 25, 2021
|
We should wait until the contrib changes are merged |
I updated the PR in contrib repo. Could you please take a look? open-telemetry/opentelemetry-collector-contrib#3451 |
|
@IrisTuntun are there any other usages left in contrib? |
carlosalberto
approved these changes
May 25, 2021
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
…kage (open-telemetry#3298) * Move BigEndian helper functions in to an internal package * revert changelog * update changelog * Change to idutils and add doc.go * Update internal/idutils/doc.go Co-authored-by: Anthony Mirabella <[email protected]> * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Move BigEndian helper functions in tracetranslator to an internal package so that external repo will not be able to access.
Link to tracking Issue: #3226
Testing:
Existing tests have been updated to use the new package.