Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how Receivers must handle errors returned by Consume*() functions #4267

Merged

Conversation

tigrannajaryan
Copy link
Member

This is important to make sure failed Consume*() calls are correctly handled
by Receivers and that the Receives in turn correctly respond back to the senders
from which they received data.

We may need to audit all receivers to make sure they work according to these
requirements.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #4267 (d4e1a05) into main (c64e6ae) will decrease coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4267      +/-   ##
==========================================
- Coverage   88.20%   87.31%   -0.90%     
==========================================
  Files         173      176       +3     
  Lines       10327    10618     +291     
==========================================
+ Hits         9109     9271     +162     
- Misses        978     1106     +128     
- Partials      240      241       +1     
Impacted Files Coverage Δ
service/collector.go 66.26% <0.00%> (ø)
model/pdata/generated_common.go 100.00% <0.00%> (ø)
model/pdata/generated_resource.go 100.00% <0.00%> (ø)
config/configauth/mock_clientauth.go 100.00% <0.00%> (ø)
config/configunmarshaler/defaultunmarshaler.go 100.00% <0.00%> (ø)
service/parserprovider/inmemory.go
service/parserprovider/default.go
service/parserprovider/properties.go
service/parserprovider/file.go
service/parserprovider/expand.go
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c64e6ae...d4e1a05. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a similar section to the Processor, also we should describe the async case like "batch".

component/receiver.go Outdated Show resolved Hide resolved
…ions

This is important to make sure failed Consume*() calls are correctly handled
by Receivers and that the Receives in turn correctly respond back to the senders
from which they received data.

We may need to audit all receivers to make sure they work according to these
requirements.
@tigrannajaryan tigrannajaryan merged commit 1636b2e into open-telemetry:main Nov 1, 2021
@tigrannajaryan tigrannajaryan deleted the receiver-behavior branch November 1, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants