-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move opentelemetry-collector-builder to core #4286
Merged
bogdandrutu
merged 42 commits into
open-telemetry:main
from
jpkrohling:jpkrohling/move-builder
Oct 28, 2021
Merged
Move opentelemetry-collector-builder to core #4286
bogdandrutu
merged 42 commits into
open-telemetry:main
from
jpkrohling:jpkrohling/move-builder
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add CODEOWNERS file * Update CODEOWNERS
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Closes #9 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Fixes #16 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
* pass errors from cobra execute back to main * print the error
…#30) * Generate a warning if the builder and collector base version mismatch * Show current default version in the warning message
Signed-off-by: Serge Catudal <[email protected]>
* Sync build and CI Go versions at latest 1.16 * Run go mod tidy * Set go binary to use in the compilation phase in tests Signed-off-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]>
* Issue#24 Add option to generate go code only (no compile) * Update cmd/root.go logging Suggested by @jpkkrohling Co-authored-by: Juraci Paixão Kröhling <[email protected]> * remove verbose help .. created by corba * suggestion by jpkrohling to keep generateandcompile * lint error: remove unused var * reword cmd option and add back help message for default Co-authored-by: Juraci Paixão Kröhling <[email protected]>
* Update to Collector v0.28.0 Closes #48 Addresses the breaking API change in open-telemetry#3163, besides the usual version number changes. Signed-off-by: Fangyi Zhou <[email protected]> * Use `go mod tidy` instead of `go mod download` It appears that this magically resolves the go.mod file issue. https://stackoverflow.com/questions/67203641/missing-go-sum-entry-for-module-providing-package-package-name Signed-off-by: Fangyi Zhou <[email protected]>
* Update replaces.builder.yaml * Update nocore.builder.yaml * Update config.go * Update README.md * Update main.go
Signed-off-by: Koichi Shiraishi <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
* Support building with Go 1.17 Fixes #65 Signed-off-by: Juraci Paixão Kröhling <[email protected]> * Update workflows to use Go 1.17 Signed-off-by: Juraci Paixão Kröhling <[email protected]> * Add gosec exceptions for exec.Command Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Fixes #67 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Fangyi Zhou <[email protected]>
* update main to include windows service code * use main version from tag 0.35.0 * update main function * align with upstream v0.36.0 tag * dummy change to trigger build * Revert "dummy change to trigger build" This reverts commit 629d499461da2d2c240bf1e495b5fe0558e3547f.
Fixes #15 Signed-off-by: yugo-horie <[email protected]>
* release 0.37.0 * update use of NewCommand
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
…' into jpkrohling/move-builder
jpkrohling
force-pushed
the
jpkrohling/move-builder
branch
from
October 28, 2021 12:08
2fe165f
to
c7b2497
Compare
bogdandrutu
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer cmd/builder please
For the whole builder repository? |
@jpkrohling yes was thinking for the whole. Let's just merge it anywhere then we can move. |
bogdandrutu
pushed a commit
that referenced
this pull request
Oct 28, 2021
This reverts commit 4063a46.
bogdandrutu
added a commit
that referenced
this pull request
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the opentelemetry-collector-builder repository to the core.
This was done by taking the builder repository, moving all its contents to the "builder" directory, adding that repository as a remote to this, and performing a merge with unrelated histories (--allow-unrelated-histories). This should not be squashed, so that the history is kept.
Closes #4275
List of commits:
- Initial commit