Move builder to cmd/builder #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
7 tasks
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4307 +/- ##
=======================================
Coverage 87.29% 87.29%
=======================================
Files 176 176
Lines 10622 10622
=======================================
Hits 9273 9273
Misses 1108 1108
Partials 241 241
Continue to review full report at Codecov.
|
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
mx-psi
approved these changes
Oct 29, 2021
codeboten
reviewed
Oct 29, 2021
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package cmd // import "go.opentelemetry.io/collector/builder/cmd" | |||
| package cmd // import "go.opentelemetry.io/collector/cmd/builder/cmd" | |||
There was a problem hiding this comment.
should this be moved out of the cmd subdirectory?
bogdandrutu
approved these changes
Oct 29, 2021
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package cmd // import "go.opentelemetry.io/collector/builder/cmd" | |||
| package cmd // import "go.opentelemetry.io/collector/cmd/builder/cmd" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4317
Signed-off-by: Juraci Paixão Kröhling [email protected]