Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename client.Client to client.Info #4416

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Nov 12, 2021

Includes documentation and how it's expected to be used by
both providers and consumers.

Fixes #4058

Signed-off-by: Juraci Paixão Kröhling [email protected]

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #4416 (c62f1aa) into main (bcb9063) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c62f1aa differs from pull request most recent head b988c01. Consider uploading reports for the commit b988c01 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4416   +/-   ##
=======================================
  Coverage   90.50%   90.51%           
=======================================
  Files         177      177           
  Lines       10357    10319   -38     
=======================================
- Hits         9374     9340   -34     
+ Misses        762      759    -3     
+ Partials      221      220    -1     
Impacted Files Coverage Δ
receiver/otlpreceiver/internal/logs/otlp.go 100.00% <ø> (ø)
receiver/otlpreceiver/internal/metrics/otlp.go 100.00% <ø> (ø)
receiver/otlpreceiver/internal/trace/otlp.go 100.00% <ø> (ø)
receiver/otlpreceiver/otlphttp.go 58.55% <ø> (-3.11%) ⬇️
client/client.go 100.00% <100.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb9063...b988c01. Read the comment docs.

@jpkrohling jpkrohling force-pushed the jpkrohling/issue4058 branch 2 times, most recently from 19f60c2 to b89f083 Compare November 12, 2021 13:47
Includes documentation and how it's expected to be used by
both providers and consumers.

Fixes open-telemetry#4058

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling marked this pull request as ready for review November 12, 2021 15:18
@jpkrohling jpkrohling requested review from a team and tigrannajaryan November 12, 2021 15:18
@jpkrohling jpkrohling marked this pull request as draft November 12, 2021 15:18
@jpkrohling
Copy link
Member Author

Even though this is ready to be reviewed, this shouldn't be merged before the v0.39.0 release, as we probably want all of the PRs in this series to be merged for the same version.

@bogdandrutu bogdandrutu marked this pull request as ready for review November 13, 2021 16:57
@jpkrohling
Copy link
Member Author

The contrib tests are expected to fail as a result of this PR:

# github.com/open-telemetry/opentelemetry-collector-contrib/processor/k8sattributesprocessor
processor/k8sattributesprocessor/pod_association.go:90:11: assignment mismatch: 2 variables but client.FromContext returns 1 value
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/internal/components [build failed]
testing: warning: no tests to run

A PR to fix this is ready (open-telemetry/opentelemetry-collector-contrib#6244) to be reviewed after the PRs for this repo are merged.

@bogdandrutu bogdandrutu merged commit 7dbf1b8 into open-telemetry:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's the use of client.Client?
3 participants