-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename client.Client to client.Info #4416
Rename client.Client to client.Info #4416
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4416 +/- ##
=======================================
Coverage 90.50% 90.51%
=======================================
Files 177 177
Lines 10357 10319 -38
=======================================
- Hits 9374 9340 -34
+ Misses 762 759 -3
+ Partials 221 220 -1
Continue to review full report at Codecov.
|
19f60c2
to
b89f083
Compare
Includes documentation and how it's expected to be used by both providers and consumers. Fixes open-telemetry#4058 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
b89f083
to
b988c01
Compare
Even though this is ready to be reviewed, this shouldn't be merged before the v0.39.0 release, as we probably want all of the PRs in this series to be merged for the same version. |
The contrib tests are expected to fail as a result of this PR:
A PR to fix this is ready (open-telemetry/opentelemetry-collector-contrib#6244) to be reviewed after the PRs for this repo are merged. |
Includes documentation and how it's expected to be used by
both providers and consumers.
Fixes #4058
Signed-off-by: Juraci Paixão Kröhling [email protected]