Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AuthData to client.Info #4422

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Add AuthData to client.Info #4422

merged 2 commits into from
Nov 22, 2021

Conversation

jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Nov 12, 2021 •
edited by bogdandrutu
Loading

Fixes #4418

Signed-off-by: Juraci Paixão Kröhling [email protected]

@codecov
Copy link

codecov bot commented Nov 12, 2021 •
edited
Loading

Codecov Report

Merging #4422 (c6d6d8c) into main (53d057f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4422   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         178      178           
  Lines       10357    10357           
=======================================
  Hits         9394     9394           
  Misses        745      745           
  Partials      218      218
Impacted Files Coverage Δ
client/client.go 89.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d057f...c6d6d8c. Read the comment docs.

@jpkrohling jpkrohling marked this pull request as ready for review November 17, 2021 17:07
@jpkrohling jpkrohling requested a review from a team November 17, 2021 17:07
@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 17, 2021
@jpkrohling
Copy link
Member Author

Skipping changelog, as it should be added as the last step.

bogdandrutu
bogdandrutu reviewed Nov 18, 2021
View reviewed changes
client/doc_test.go Outdated Show resolved Hide resolved
client/doc_test.go Outdated Show resolved Hide resolved
@jpkrohling
Add AuthData to client.Info
e6fb057 
Fixes open-telemetry#4418

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling
Handle attribute in doc example
c6d6d8c 
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling
Copy link
Member Author

@bogdandrutu, @tigrannajaryan, do you mind merging this one?

@bogdandrutu bogdandrutu merged commit ac9619e into open-telemetry:main Nov 22, 2021
@jpkrohling jpkrohling mentioned this pull request Nov 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AuthData to client.Info
2 participants
@jpkrohling @bogdandrutu