-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate client.Info from config helpers #4423
Populate client.Info from config helpers #4423
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4423 +/- ##
==========================================
+ Coverage 90.67% 90.71% +0.03%
==========================================
Files 179 181 +2
Lines 10450 10460 +10
==========================================
+ Hits 9476 9489 +13
+ Misses 757 755 -2
+ Partials 217 216 -1
Continue to review full report at Codecov.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
09e697d
to
132759a
Compare
bada4a5
to
0f18ea4
Compare
CI is currently failing due to #4470 |
fe705ae
to
8813c6f
Compare
8813c6f
to
279c255
Compare
Rebased. @bogdandrutu, could you please review/merge? |
279c255
to
c1c418c
Compare
This is ready for another review, @bogdandrutu. |
@bogdandrutu, would you please review and merge this one? |
@jpkrohling will merge after contrib is updated with the latest breaking change to not have multiple breaking changes in the same time. |
Fixes open-telemetry#4419 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
3c89ae4
to
8164553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a conversation with the folks from the go-grpc-middleware project, the PingService isn't part of their public API and I shouldn't be using it. As such, there's no point in adding that dependency anymore.
From your last review, these are the main changes:
- internal/middleware now has a WrappedStream type, based on your previous suggestion and on go-grpc-middleware implementation
- the tests that were using the PingService are not using the mock trace server based on the OTLP Traces
- a simple unit test was added to cover the streaming case, which was previously covered in a scenario closer to the real world with a real streaming service
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Fixes #4419
Signed-off-by: Juraci Paixão Kröhling [email protected]