Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SchemaURL in OTLP text #4500

Merged

Conversation

tigrannajaryan
Copy link
Member

This enables printing SchemaURL in logging exporter.

This enables printing SchemaURL in logging exporter.
@tigrannajaryan tigrannajaryan added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 1, 2021
@tigrannajaryan tigrannajaryan marked this pull request as ready for review December 1, 2021 19:40
@tigrannajaryan tigrannajaryan requested review from a team and jpkrohling December 1, 2021 19:40
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #4500 (e31a942) into main (aee2d67) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4500   +/-   ##
=======================================
  Coverage   90.77%   90.78%           
=======================================
  Files         179      179           
  Lines       10412    10418    +6     
=======================================
+ Hits         9452     9458    +6     
  Misses        743      743           
  Partials      217      217           
Impacted Files Coverage Δ
internal/otlptext/logs.go 100.00% <100.00%> (ø)
internal/otlptext/metrics.go 100.00% <100.00%> (ø)
internal/otlptext/traces.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee2d67...e31a942. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 91fac6c into open-telemetry:main Dec 2, 2021
@tigrannajaryan tigrannajaryan deleted the logging-schemaurl branch December 2, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants