confighttp: add component.Host parameter to ToServer
#4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4514 +/- ##
==========================================
- Coverage 90.68% 90.66% -0.03%
==========================================
Files 179 179
Lines 10425 10429 +4
==========================================
+ Hits 9454 9455 +1
- Misses 755 757 +2
- Partials 216 217 +1
Continue to review full report at Codecov.
|
c4c9533
to
575c412
Compare
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
575c412
to
bc19bb3
Compare
mx-psi
reviewed
Dec 6, 2021
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
mx-psi
approved these changes
Dec 6, 2021
bogdandrutu
reviewed
Dec 6, 2021
| componenttest.NewNopTelemetrySettings(), | ||
| http.HandlerFunc(func(http.ResponseWriter, *http.Request) {})) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Just require no error is the same.
There was a problem hiding this comment.
This is within an Example code, not a test.
bogdandrutu
approved these changes
Dec 6, 2021
jpkrohling
added a commit
to jpkrohling/opentelemetry-collector-contrib
that referenced
this pull request
Dec 7, 2021
The PR open-telemetry/opentelemetry-collector#4514 brought breaking changes to confighttp. This PR migrates the consumers of that to the new signature. Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 7, 2021
The PR open-telemetry/opentelemetry-collector#4514 brought breaking changes to confighttp. This PR migrates the consumers of that to the new signature. Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4512 by adding the component.Host parameter to the confighttp.ToServer function, in preparation for the changes related to configauth. This also changes the order of arguments, to make it consistent with configgrpc.
Signed-off-by: Juraci Paixão Kröhling [email protected]