Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit grpc-ecosystem/go-grpc-middleware for WrappedServerStream #4531

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

jpkrohling
Copy link
Member

Fixes #4521

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling jpkrohling requested review from a team and bogdandrutu December 9, 2021 10:44
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #4531 (c21fad8) into main (95201d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4531   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files         180      180           
  Lines       10466    10466           
=======================================
  Hits         9476     9476           
  Misses        774      774           
  Partials      216      216           
Impacted Files Coverage Δ
internal/middleware/wrappedstream.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95201d4...c21fad8. Read the comment docs.

@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 9, 2021
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The credit is already there since we kept the copyright, I was mostly thinking to add this for others to know where to look for changes or other things.

@bogdandrutu bogdandrutu merged commit 02cab16 into open-telemetry:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a comment in the class description that code "inspired/copied" from and a link to the code.
2 participants