Remove interceptors from configauth interface #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#4582 Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4583 +/- ##
==========================================
- Coverage 90.73% 90.69% -0.04%
==========================================
Files 180 179 -1
Lines 10605 10600 -5
==========================================
- Hits 9622 9614 -8
- Misses 765 767 +2
- Partials 218 219 +1
Continue to review full report at Codecov.
|
jpkrohling
commented
Dec 20, 2021
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| ctx, err := authenticate(r.Context(), r.Header) | ||
| if err != nil { | ||
| http.Error(w, http.StatusText(http.StatusUnauthorized), http.StatusUnauthorized) |
There was a problem hiding this comment.
This is missing a test, tracked via #4555
bogdandrutu
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4582
Signed-off-by: Juraci Paixão Kröhling [email protected]