-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to OTLP proto 0.12.0 #4724
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4724 +/- ##
==========================================
- Coverage 90.73% 90.68% -0.06%
==========================================
Files 179 179
Lines 10696 10541 -155
==========================================
- Hits 9705 9559 -146
+ Misses 770 763 -7
+ Partials 221 219 -2
Continue to review full report at Codecov.
|
3eb0aad
to
d9107d2
Compare
@open-telemetry/collector-approvers please review the deletions of metrics code carefully. I want to make sure I didn't break anything and didn't delete any code that was supposed to stay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets a bit hard to follow the changes in the generated *.pb.go
files, but it looked like the metrics changes were what I'd expect. The deprecated types were removed and from there it looked like noise from shuffling things around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes all look good, I'd like to merge this after this next release though
Yes, let's hold this until the release is done. |
d9107d2
to
56b2dea
Compare
56b2dea
to
6af7a67
Compare
- Removed all deprecated metric messages and corresponding conversion code and tests. - Removed deprecated_code from span status and corresponding conversions and tests. - Renamed logs field to log_records in InstrumentationLibraryLogs message.
6af7a67
to
165ecee
Compare
Resolves #4717