Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.45.0 #4868

Merged

Conversation

jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Feb 16, 2022

Contrib PR: open-telemetry/opentelemetry-collector-contrib#7937

Closes #4871

Signed-off-by: Juraci Paixão Kröhling [email protected]

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling requested review from a team and bogdandrutu February 16, 2022 09:52
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #4868 (5a4dd46) into main (8399098) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4868   +/-   ##
=======================================
  Coverage   90.60%   90.60%           
=======================================
  Files         180      180           
  Lines       10622    10622           
=======================================
  Hits         9624     9624           
  Misses        779      779           
  Partials      219      219           
Impacted Files Coverage Δ
cmd/builder/internal/builder/config.go 83.82% <ø> (ø)
cmd/otelcorecol/main.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8399098...5a4dd46. Read the comment docs.

@jpkrohling
Copy link
Member Author

codecov failing because there's 0% of diff hit... Seriously, codecov? :-)

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple questions, but can be merged.

### 🛑 Breaking changes 🛑

- Remove deprecated funcs in configtelemetry (#4808)
- Deprecate `service/defaultcomponents` go package (#4622)
- `otlphttp` and `otlp` exporters enable gzip compression by default (#4632)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was incorrectly added to 0.44.0, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, I moved them here to reflect the right version they got in.

@@ -2,29 +2,29 @@ dist:
module: go.opentelemetry.io/collector/cmd/otelcorecol
name: otelcorecol
description: Local OpenTelemetry Collector binary, testing only.
version: 0.43.1-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this version affect? Did we incorrectly release 0.44.0 without updating this field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is what's displayed in the logs when you run make run. This distribution is only used for local debugging. The other versions on this file also don't matter that much, as the replaces statement down there points to the file system location for the modules.

@jpkrohling
Copy link
Member Author

but can be merged

If it's OK, would you please merge it? I can't merge it myself :-)

@tigrannajaryan tigrannajaryan merged commit dacd8a2 into open-telemetry:main Feb 16, 2022
@jpkrohling jpkrohling added this to the v0.45.0 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare core release v0.45.0
2 participants