-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare v0.45.0 #4868
Prepare v0.45.0 #4868
Conversation
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4868 +/- ##
=======================================
Coverage 90.60% 90.60%
=======================================
Files 180 180
Lines 10622 10622
=======================================
Hits 9624 9624
Misses 779 779
Partials 219 219
Continue to review full report at Codecov.
|
codecov failing because there's 0% of diff hit... Seriously, codecov? :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple questions, but can be merged.
### 🛑 Breaking changes 🛑 | ||
|
||
- Remove deprecated funcs in configtelemetry (#4808) | ||
- Deprecate `service/defaultcomponents` go package (#4622) | ||
- `otlphttp` and `otlp` exporters enable gzip compression by default (#4632) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was incorrectly added to 0.44.0, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I moved them here to reflect the right version they got in.
@@ -2,29 +2,29 @@ dist: | |||
module: go.opentelemetry.io/collector/cmd/otelcorecol | |||
name: otelcorecol | |||
description: Local OpenTelemetry Collector binary, testing only. | |||
version: 0.43.1-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this version affect? Did we incorrectly release 0.44.0 without updating this field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is what's displayed in the logs when you run make run
. This distribution is only used for local debugging. The other versions on this file also don't matter that much, as the replaces statement down there points to the file system location for the modules.
If it's OK, would you please merge it? I can't merge it myself :-) |
Contrib PR: open-telemetry/opentelemetry-collector-contrib#7937
Closes #4871
Signed-off-by: Juraci Paixão Kröhling [email protected]