Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated log name from text marshaler #5172

Merged

Conversation

djaglowski
Copy link
Member

LogRecord.Name has been deprecated, but there is still a reference to it in the logging exporter. This change removes the name from the logging exporter output.

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #5172 (4517b9a) into main (95b976f) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5172      +/-   ##
==========================================
+ Coverage   90.33%   90.37%   +0.03%     
==========================================
  Files         185      185              
  Lines       11000    10999       -1     
==========================================
+ Hits         9937     9940       +3     
+ Misses        837      834       -3     
+ Partials      226      225       -1     
Impacted Files Coverage Δ
internal/otlptext/logs.go 100.00% <ø> (ø)
model/internal/common.go 95.06% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b976f...4517b9a. Read the comment docs.

@djaglowski djaglowski marked this pull request as ready for review April 9, 2022 18:28
@djaglowski djaglowski requested review from a team and tigrannajaryan April 9, 2022 18:28
@tigrannajaryan tigrannajaryan merged commit 418ae40 into open-telemetry:main Apr 11, 2022
@djaglowski djaglowski deleted the rm-logname-textmarshaler branch April 11, 2022 14:00
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
LogRecord.Name has been deprecated, but there is still a reference to it in the logging exporter. This change removes the name from the logging exporter output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants