Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependency on gorrila mux #5184

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and jpkrohling April 11, 2022 17:30
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #5184 (38a1bde) into main (66900f2) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #5184      +/-   ##
==========================================
+ Coverage   90.32%   90.34%   +0.02%     
==========================================
  Files         185      185              
  Lines       11041    11046       +5     
==========================================
+ Hits         9973     9980       +7     
  Misses        841      841              
+ Partials      227      225       -2     
Impacted Files Coverage Δ
receiver/otlpreceiver/otlp.go 87.58% <90.00%> (+1.67%) ⬆️
config/configmap.go 89.58% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66900f2...38a1bde. Read the comment docs.

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 11, 2022
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that there are no changes to the tests and they are passing, I assume it proves that no breaking changes were introduced.

@bogdandrutu bogdandrutu merged commit 02ce41b into open-telemetry:main Apr 11, 2022
@bogdandrutu bogdandrutu deleted the rmgorilla branch April 11, 2022 22:40
Nicholaswang pushed a commit to Nicholaswang/opentelemetry-collector that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants