Update BoundedMemoryQueue to consume remaining items on close #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5203 +/- ##
==========================================
+ Coverage 90.34% 90.39% +0.04%
==========================================
Files 187 187
Lines 11079 11051 -28
==========================================
- Hits 10009 9989 -20
+ Misses 844 839 -5
+ Partials 226 223 -3
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Apr 14, 2022
bogdandrutu
reviewed
Apr 14, 2022
bogdandrutu
approved these changes
Apr 14, 2022
|
@TylerHelmuth please add a changelog entry. |
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…elemetry#5203) * BoundedMemoryQueue now consumes on close * Add back !ok return * Removed stopCh * Cleanup * Updated CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updated the BoundedMemoryQueue to consume any remaining items on shutdown. The timing of the colsure of the items queue during
Stop()has been moved up so that items in the queue can be consumed in a non-blocking way.Link to tracking Issue:
Fixes #5110
Testing:
Unit Tests