Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Delete pdata func from (v0.47.0) #5307

Merged

Conversation

codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten force-pushed the codeboten/cleanup-deprecated branch from a049a71 to 90fcb1e Compare May 3, 2022 22:51
@codeboten codeboten marked this pull request as ready for review May 3, 2022 22:51
@codeboten codeboten requested review from a team and bogdandrutu May 3, 2022 22:51
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #5307 (90fcb1e) into main (041f398) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5307      +/-   ##
==========================================
+ Coverage   90.53%   90.58%   +0.05%     
==========================================
  Files         190      190              
  Lines       11111    11109       -2     
==========================================
+ Hits        10059    10063       +4     
+ Misses        829      824       -5     
+ Partials      223      222       -1     
Impacted Files Coverage Δ
pdata/internal/common.go 95.38% <ø> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041f398...90fcb1e. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 9be6ecc into open-telemetry:main May 3, 2022
CatherineF-dev added a commit to CatherineF-dev/opentelemetry-collector that referenced this pull request Jul 11, 2022
 `pdata.Remove` is the replacement for `pdata.Delete` 

open-telemetry#5307
codeboten pushed a commit that referenced this pull request Jul 19, 2022
`pdata.Remove` is the replacement for `pdata.Delete` 

#5307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants