Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to go.pkg.in/yaml.v3 #5441

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented May 30, 2022

Description: Bump YAML dependency to v3, which was recently released. Changes are listed here https://github.com/go-yaml/yaml#compatibility.

Open question: Does this need a changelog? It does have some user-facing changes (e.g. on/off are now valid boolean values)

@mx-psi mx-psi requested review from a team and codeboten May 30, 2022 11:58
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #5441 (166b6a0) into main (3613ead) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5441      +/-   ##
==========================================
- Coverage   90.96%   90.88%   -0.08%     
==========================================
  Files         190      190              
  Lines       11424    11424              
==========================================
- Hits        10392    10383       -9     
- Misses        813      820       +7     
- Partials      219      221       +2     
Impacted Files Coverage Δ
config/internal/configsource/manager.go 85.95% <ø> (-1.44%) ⬇️
config/mapprovider/envmapprovider/mapprovider.go 100.00% <ø> (ø)
config/mapprovider/filemapprovider/mapprovider.go 100.00% <ø> (ø)
config/mapprovider/yamlmapprovider/mapprovider.go 100.00% <ø> (ø)
pdata/internal/common.go 94.61% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3613ead...166b6a0. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok without a changelog for this, since on/off is only there to be backwards compatible with yaml 1.1, and we were already compatible with 1.2

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 31, 2022
@bogdandrutu bogdandrutu merged commit 8dfdc1c into open-telemetry:main May 31, 2022
@mx-psi mx-psi deleted the mx-psi/yaml.v3 branch June 1, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants