Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move extensions for internal to public package #5606

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Move extensions for internal to public package #5606

merged 1 commit into from
Jul 25, 2022

Conversation

bogdandrutu
Copy link
Member

Updates #5564

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan June 29, 2022 13:24
@codecov
Copy link

codecov bot commented Jun 29, 2022 •
edited
Loading

Codecov Report

Merging #5606 (f19d8ba) into main (96de81b) will decrease coverage by 0.00%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main    #5606      +/-   ##
==========================================
- Coverage   91.56%   91.56%   -0.01%     
==========================================
  Files         192      192              
  Lines       11411    11410       -1     
==========================================
- Hits        10449    10448       -1     
  Misses        768      768              
  Partials      194      194
Impacted Files Coverage Δ
service/host.go 100.00% <ø> (ø)
service/service.go 62.96% <57.14%> (-0.46%) ⬇️
service/extensions/extensions.go 82.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96de81b...f19d8ba. Read the comment docs.

mx-psi
mx-psi reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, also needs changelog entry

service/extensions/config.go Show resolved Hide resolved
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 20, 2022
@mx-psi mx-psi removed the Stale label Jul 20, 2022
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 25, 2022
@bogdandrutu bogdandrutu merged commit ce1603b into open-telemetry:main Jul 25, 2022
@bogdandrutu bogdandrutu deleted the mvextensions branch July 25, 2022 16:08
@mx-psi mx-psi mentioned this pull request Sep 14, 2022
Merged
This was referenced Sep 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@mx-psi mx-psi mx-psi approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdandrutu @tigrannajaryan @mx-psi @TylerHelmuth