Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]fix some grammatical mistakes in readmes #5607

Merged
merged 6 commits into from
Jul 5, 2022

Conversation

qyqcswill
Copy link
Contributor

grammatical error:
Documentation: processor/batchprocessor/README.md has a grammatical error

fix
grammatical error
@qyqcswill qyqcswill requested review from a team and Aneurysm9 June 30, 2022 00:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@qyqcswill qyqcswill closed this Jun 30, 2022
@qyqcswill qyqcswill reopened this Jun 30, 2022
@qyqcswill qyqcswill changed the title docs[] [docs] Jun 30, 2022
grammatical error
@TylerHelmuth
Copy link
Member

@qyqcswill it looks like you've signed the CLA but the commits don't have your UserID associated with them. Checked this guide to fix that.. The PR can't be accepted until it is fixed.

@qyqcswill
Copy link
Contributor Author

qyqcswill commented Jul 1, 2022

@qyqcswill it looks like you've signed the CLA but the commits don't have your UserID associated with them. Checked this guide to fix that.. The PR can't be accepted until it is fixed.

OK, I reset commit, thank you!

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #5607 (95a1422) into main (b094dbd) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5607      +/-   ##
==========================================
- Coverage   91.29%   91.24%   -0.05%     
==========================================
  Files         191      191              
  Lines       11291    11308      +17     
==========================================
+ Hits        10308    10318      +10     
- Misses        782      789       +7     
  Partials      201      201              
Impacted Files Coverage Δ
...er/loggingexporter/internal/otlptext/databuffer.go 99.12% <0.00%> (-0.88%) ⬇️
service/internal/extensions/extensions.go 82.97% <0.00%> (-0.86%) ⬇️
pdata/internal/common.go 91.85% <0.00%> (-0.75%) ⬇️
service/collector.go 76.22% <0.00%> (-0.33%) ⬇️
component/exporter.go 100.00% <0.00%> (ø)
component/receiver.go 100.00% <0.00%> (ø)
component/processor.go 100.00% <0.00%> (ø)
config/moved_config.go 100.00% <0.00%> (ø)
config/configtls/configtls.go 100.00% <0.00%> (ø)
exporter/otlpexporter/otlp.go 90.42% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b094dbd...95a1422. Read the comment docs.

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 4, 2022
@mx-psi
Copy link
Member

mx-psi commented Jul 4, 2022

@qyqcswill can you write a more descriptive PR title?

@qyqcswill qyqcswill changed the title [docs] [docs]fix some grammatical mistakes in readmes Jul 4, 2022
@codeboten codeboten merged commit 16aa10d into open-telemetry:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants